Skip to content

SMT2 back-end: CVC5 does not support lambda expressions #7676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

SMT2 back-end: CVC5 does not support lambda expressions #7676

merged 1 commit into from
Apr 20, 2023

Conversation

tautschnig
Copy link
Collaborator

I wrongly asserted (in 8fdb8bb) that CVC5 supports lambda. It seemingly does not, as can also be confirmed using Z3's test https://github.com/Z3Prover/z3test/blob/master/regressions/smt2/memset.smt2.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
SMT2 back-end: CVC5 does not support lambda expressions
b8bd6c6 
I wrongly asserted (in 8fdb8bb) that CVC5 supports lambda. It
seemingly does not, as can also be confirmed using Z3's test
https://github.com/Z3Prover/z3test/blob/master/regressions/smt2/memset.smt2.
@tautschnig tautschnig requested a review from kroening as a code owner April 20, 2023 10:55
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (b1b39e8) 78.52% compared to head (b8bd6c6) 78.42%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7676      +/-   ##
===========================================
- Coverage    78.52%   78.42%   -0.10%     
===========================================
  Files         1674     1674              
  Lines       191972   191971       -1     
===========================================
- Hits        150738   150562     -176     
- Misses       41234    41409     +175
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 67.41% <ø> (+0.02%) ⬆️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 793801c into diffblue:develop Apr 20, 2023
@tautschnig tautschnig deleted the bugfixes/cvc5-no-lambda branch April 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@thomasspriggs thomasspriggs Awaiting requested review from thomasspriggs

@NlightNFotis NlightNFotis Awaiting requested review from NlightNFotis

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB is a code owner

Assignees

@martin-cs martin-cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @kroening @martin-cs